Repository navigation
fix(library): PageUp/PageDown in note editor no longer scrolls the block off screen - #51
Merged
Merged
Conversation
…the block off screen Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6QMXXvRReaKxWk1JL5Et6
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PageUp/PageDown in the notes editor could shift the whole block up until its top edge was off screen. When the textarea can't scroll further, the browser chains the page key to the nearest scrollable ancestor, and an overflow:hidden ancestor (the block) still scrolls programmatically. The editor now records its ancestors' scroll positions on those keys and restores them if they move (for 250 ms after the key).
Status
Cause inferred from the symptom and the layout; not reproduced without the running app.
Routes
Purely a local UI fix in the editor; identical on plain-SSH and wsh hosts (host notes and general notes share the editor).
Test plan
npx vitest runpasses; prettier clean; tsc unchanged (16 pre-existing errors).🤖 Generated with Claude Code
https://claude.ai/code/session_01W6QMXXvRReaKxWk1JL5Et6